Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add recommendations for WordPress workflow #16622

Merged
merged 4 commits into from
Aug 15, 2019
Merged

docs: Add recommendations for WordPress workflow #16622

merged 4 commits into from
Aug 15, 2019

Conversation

gillkyle
Copy link
Contributor

@gillkyle gillkyle commented Aug 14, 2019 •
edited by sidharthachatterjee
Loading

Description

Clarifies recommendations for the setting up a blog from WordPress workflow.

Related Issues

Fixes #13876
Related to #13708

@gillkyle gillkyle added the type: documentation An issue or pull request for improving or updating Gatsby's documentation label Aug 14, 2019
@gillkyle gillkyle requested a review from a team as a code owner August 14, 2019 16:47
@amberleyromo amberleyromo self-assigned this Aug 15, 2019
sidharthachatterjee
sidharthachatterjee previously approved these changes Aug 15, 2019
View reviewed changes
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Left a few suggestions 🥇

docs/docs/sourcing-from-wordpress.md Outdated Show resolved Hide resolved
docs/docs/sourcing-from-wordpress.md Outdated Show resolved Hide resolved
docs/docs/sourcing-from-wordpress.md Outdated Show resolved Hide resolved
docs/docs/sourcing-from-wordpress.md Outdated Show resolved Hide resolved
docs/docs/sourcing-from-wordpress.md Outdated Show resolved Hide resolved
docs/docs/sourcing-from-wordpress.md Outdated Show resolved Hide resolved
@sidharthachatterjee sidharthachatterjee changed the title docs: added recommendations for WordPress workflow docs: Add recommendations for WordPress workflow Aug 15, 2019
@gillkyle @sidharthachatterjee
Apply suggestions from Sids code review
fb3f447 
Co-Authored-By: Sidhartha Chatterjee <me@sidharthachatterjee.com>
sidharthachatterjee
sidharthachatterjee previously approved these changes Aug 15, 2019
View reviewed changes
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sidharthachatterjee sidharthachatterjee added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Aug 15, 2019
sidharthachatterjee
sidharthachatterjee approved these changes Aug 15, 2019
View reviewed changes
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gatsbybot gatsbybot merged commit dce32e5 into master Aug 15, 2019
@wardpeet wardpeet deleted the wordpress-workflow-recommendations branch August 23, 2019 09:02
@louiechristie louiechristie mentioned this pull request Sep 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidharthachatterjee sidharthachatterjee sidharthachatterjee approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[docs] [workflows] Improve docs for setting up a blog that pulls content from WordPress
4 participants
@gillkyle @sidharthachatterjee @amberleyromo @gatsbybot